Skip to content

fix: Linux menu items for empty menus#110

Merged
Dimillian merged 4 commits intomainfrom
codex/github-mention-menu-buttons-empty
Jan 19, 2026
Merged

fix: Linux menu items for empty menus#110
Dimillian merged 4 commits intomainfrom
codex/github-mention-menu-buttons-empty

Conversation

@Dimillian
Copy link
Owner

Motivation

  • GTK on Linux was showing empty menus because the macOS/Predefined menu configuration did not produce visible items on Linux, so Linux needs explicit menu items and handlers.

Description

  • Add Linux-specific menu constructions for File, View, Window, and Help using MenuItemBuilder behind #[cfg(target_os = "linux")] in src-tauri/src/lib.rs.
  • Preserve the existing PredefinedMenuItem usage for non-Linux platforms by keeping the #[cfg(not(target_os = "linux"))] branches.
  • Update the .on_menu_event handler to match the new Linux-specific item IDs and perform actions for about/help_about, file_close_window/window_close, file_quit, view_fullscreen, window_minimize, and window_maximize (show About window, close main window, exit app, toggle fullscreen, minimize, maximize).
  • Change is limited to src-tauri/src/lib.rs and wires Linux menu items so GTK displays non-empty menus.

Testing

  • Ran npm run lint and it completed successfully (ESLint emitted a TypeScript version warning but exited with success).
  • Ran npm run typecheck (tsc --noEmit) and it completed successfully.

Codex Task

@Dimillian Dimillian changed the title Fix Linux menu items for empty menus fix: Linux menu items for empty menus Jan 19, 2026
@Dimillian
Copy link
Owner Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 33dd9a2c21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit bf2e6b5 into main Jan 19, 2026
2 checks passed
gersmann pushed a commit to gersmann/codex-monitor-web that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant